[ML] Allow github-actions[bot] to trigger ml-cpp-pr-builds CI#3103
Merged
Conversation
Backport PRs opened by the auto-backport workflow are authored by github-actions[bot], which is not an org member, so buildkite-pr-bot's org-membership path never matches it and no build is triggered. Add the bot to allowed_list so its PRs (backports) get the full CI matrix, matching elastic/elasticsearch (see elasticsearch#147815). Fixes elastic#3099 Co-authored-by: Cursor <[email protected]>
|
Pinging @elastic/ml-core (Team:ML) |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport PRs opened by our auto-backport workflow are authored by
github-actions[bot].buildkite-pr-botdecides whether to triggerml-cpp-pr-buildsfrom the push/PR sender identity, via three allow paths (seeelastic/buildkite-pr-bot):allowed_listmembershipadmin/writepermission on the base repoallow_org_users: true+ Elastic org membershipBot accounts (logins ending
[bot]) cannot be org members, so path 3 never matches them, and we don't list them anywhere — so bot-authored backports get no Buildkite build. OnlyCLA,Check labels, and Snyk run; the build/test matrix never starts, and auto-merge (once approval is sorted) can't rely on CI.This adds
github-actions[bot]toallowed_list(path 1), so its PRs — i.e. the automated backports — trigger the full matrix like any human-authored PR.This is exactly the fix
elastic/elasticsearchapplied in elasticsearch#147815 ("Update allowed list in pull-requests.json"), whoseallowed_listalready containsgithub-actions[bot]andelastic-vault-github-plugin-prod[bot].Notes
buildkite-pr-botreads.buildkite/pull-requests.jsonfrom the repo's default branch (main), not the PR base branch (src/config.ts:configBranch || 'main'). So this single change onmaincovers backports targeting every release branch — no per-branch edit needed.buildkite-pr-botaselasticmachine, so it satisfies the pipeline'sfilter_condition(build.creator.name == 'elasticmachine').elastic-vault-github-plugin-prod[bot]here too (as ES does).Addresses the CI-trigger half of the stall; the approval half is tracked separately (#3094).
Fixes #3099
Test plan
main.>bugPR carrying version labels so the auto-backport workflow opens backport PRs authored bygithub-actions[bot].ml-cpp-pr-buildsbuild within ~seconds of opening (creatorelasticmachine), without a manualbuildkite buildcomment.